> On 22 Jul 2021, at 07:28, vignesh C <vignesh21@gmail.com> wrote:
>
> On Thu, Jul 1, 2021 at 6:41 AM Gurjeet Singh <gurjeet@singh.im> wrote:
>>
>> The proposed patch is attached.
>
> There is one compilation warning:
> xid.c:165:1: warning: no previous prototype for
> ‘FullTransactionIdToStr’ [-Wmissing-prototypes]
> 165 | FullTransactionIdToStr(FullTransactionId fxid)
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> There are few compilation issues in documentation:
> /usr/bin/xmllint --path . --noout --valid postgres.sgml
> protocol.sgml:1327: parser error : Opening and ending tag mismatch:
> literal line 1322 and para
> </para>
> ^
> protocol.sgml:1339: parser error : Opening and ending tag mismatch:
> literal line 1322 and sect2
> </sect2>
> ^
> protocol.sgml:1581: parser error : Opening and ending tag mismatch:
> para line 1322 and sect1
> </sect1>
> ^
> protocol.sgml:7893: parser error : Opening and ending tag mismatch:
> sect2 line 1322 and chapter
> </chapter>
> ^
> protocol.sgml:7894: parser error : chunk is not well balanced
>
> ^
> postgres.sgml:253: parser error : Failure to process entity protocol
> &protocol;
> ^
> postgres.sgml:253: parser error : Entity 'protocol' not defined
> &protocol;
> ^
The above compiler warning and documentation compilation errors haven't been
addressed still, so I'm marking this patch Returned with Feedback. Please feel
free to open a new entry for an updated patch.
--
Daniel Gustafsson https://vmware.com/