Re: pgsql: Move strtoint() to common

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Move strtoint() to common
Дата
Msg-id 24955.1521041015@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: Move strtoint() to common  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Ответы Re: pgsql: Move strtoint() to common  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-committers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> I think the problem is rather that we somehow need to tell it to link
> src/common/string.c into pgtypeslib.

Yeah, that's what I supposed.

Looking at pgtypeslib, there's already infrastructure for collecting
stuff from src/port/, and I see you added some for src/common/ in
its Makefile, but evidently not in the MSVC scripts.  It looks like
the way the MSVC build works now is dependent on @pgportfiles.

You could invent parallel infrastructure for src/common/, but I wonder
whether the path of least resistance might not be to put strtoint()
into src/port/ instead.

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Log when a BRIN autosummarization request fails
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: pgsql: Add Oracle like handling of char arrays.