On 02/27/2017 01:02 PM, Andres Freund wrote:
> Hi,
>
> On 2017-02-27 03:17:32 -0800, Andres Freund wrote:
>> I'll work on getting slab committed first, and then review / edit /
>> commit generation.c later. One first note there is that I'm wondering
>> if generation.c is a too generic filename.
>
> And pushed slab and its usage. Will have a look at generation.c
> tomorrow.
>
> - Andres
>
Gah. I don't want to annoy person who just committed my patch, but can
you give more time when asking for feedback? I mean, sending a modified
patch on Friday midnight, and committing on Monday noon does not really
give much time to look at it.
The changes seem fine to me, thanks for spending time on this.
Thanks
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services