Re: pg_dumpall segfault

Nick Eskelinen <nickesk@bu.edu> writes:
> Ahh... as a matter of fact I do. Adding someone to this empty group
> corrects the problem.

Thought so.  I've committed a fix if you need it:

*** src/bin/pg_dump/pg_dumpall.c.orig    Thu Mar  6 16:45:52 2003
--- src/bin/pg_dump/pg_dumpall.c    Fri Mar 14 17:41:56 2003
***************
*** 327,333 ****

          val = strdup(PQgetvalue(res, i, 2));
          tok = strtok(val, ",{}");
!         do
          {
              PGresult   *res2;
              PQExpBuffer buf2 = createPQExpBuffer();
--- 327,333 ----

          val = strdup(PQgetvalue(res, i, 2));
          tok = strtok(val, ",{}");
!         while (tok)
          {
              PGresult   *res2;
              PQExpBuffer buf2 = createPQExpBuffer();
***************
*** 347,353 ****

              tok = strtok(NULL, "{},");
          }
!         while (tok);

          printf("%s", buf->data);
          destroyPQExpBuffer(buf);
--- 347,353 ----

              tok = strtok(NULL, "{},");
          }
!         free(val);

          printf("%s", buf->data);
          destroyPQExpBuffer(buf);

            regards, tom lane