Grzegorz Jaśkiewicz <gryzman@gmail.com> writes:
> It would crash if input is of unrecognized format. Probably than
> there's going to be more problems to be concerned with, but just in
> case, don't crash in
I'm not sure why you think this is a good change, but it would break
things: in particular, the code would fail to null-terminate the string
in the hex-output case. Also, the case that you seem to be trying to
defend against can't happen because elog(ERROR) doesn't return.
regards, tom lane