Re: [COMMITTERS] pgsql: Add pg_sequence system catalog

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> It looks like the catalog data is written without padding (relid(4),
> start(8), inc(8), max(8), min(8), ...) but read with padding (relid(4),
> padding(4), start(8), inc(8), max(8), min(8), ...).  The difference is
> that the write goes through heap_form_tuple but the read uses the Form_
> struct.  What is suspicious is this from the configure output:

> checking alignment of short... 2
> checking alignment of int... 4
> checking alignment of long... 4
> checking alignment of long long int... 8
> checking alignment of double... 4

> We use DOUBLEALIGN to align int64 values, but on this platform, that is
> not correct.

Quickest solution might be to reorder the columns of pg_sequence to
avoid wasting padding bytes, ie, put seqcycle after seqrelid.

            regards, tom lane