Shridhar Daithankar <shridhar@frodo.hserus.net> writes:
> Any updates/opinions? Should we convert assign hooks to perform actual
> assignment and custom validation instead of just custom validation? It is
> clear from README that it is for validation purposes only..
As it should be. Assign hooks have no business altering the
user-supplied value.
We do have provisions for letting string assign hooks do that, but the
intended use of this was just for trivial display adjustments like
case-normalizing time zone names.
I remain unalterably opposed to the notion of measuring shared_buffers
in KB, but if you think you can get such a thing in over my objections,
the way to do it is to decouple the GUC parameter from NBuffers. The
GUC setting is whatever it is; you can reject the value if it's too
far out of range, but you do not editorialize upon it. What you do is
compute the derived value for NBuffers and assign that in the assign
hook.
regards, tom lane