Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I think you may have converted some malloc() calls from Andres' patch
> into palloc() -- because you have some palloc() calls which are later
> checked for NULL results, which obviously doesn't make sense. At the
> same time, if we're going to use malloc() instead of palloc(), we need
> to check for NULL return value in XLogReaderAllocate() callers. This
> seems easy to fix at first glance, but what is the correct response if
> it fails during StartupXLOG()? Should we just elog(FATAL) and hope it
> never happens in practice?
Um, surely we can still let those functions use palloc? It should
just be #define'd as pg_malloc() (ie something with an error exit)
in non-backend contexts.
regards, tom lane