Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode
| От | Jonathan Gonzalez V. |
|---|---|
| Тема | Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode |
| Дата | |
| Msg-id | 2373b0487573c9f780590709881ecc84e965abcc.camel@gmail.com обсуждение исходный текст |
| Ответ на | Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode (Jacob Champion <jacob.champion@enterprisedb.com>) |
| Ответы |
Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode
|
| Список | pgsql-hackers |
Hi! > > +#define conn_oauth_ca_file(CONN) (CONN->oauth_ca_file) > > Arrrghh I hadn't even considered that this thread would conflict with > the changes over at [1]. Well, the silver lining is that I already > know I have to get most of that work in; this just serializes things. Well, it will definitely conflict but I can rebase the work on that patch, not an issue, since now I understand what you mean it's even more fun! What do you think? I can do some testing and review on those patches too while working on a rebase, so I think it's a win-win > > I want to add some test for this option that I think it could be > > really > > useful, what do you think? > > Definitely. I could see either upgrading the oauth_validator test > suite to use HTTPS throughout, and then setting the new envvar > globally, or just adding a single test that switches it on (but I'm > not sure that's actually less work, since you have to teach > oauth_server.py to speak HTTPS either way). Ok, so probably a new patch to teach oauth_server.py to speak HTTPS could be good? Since it requires to create certificates and lot of testing work a different patch could be better right? just to add HTTPS support. Thank you! -- Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> EnterpriseDB
Вложения
В списке pgsql-hackers по дате отправления: