Re: How does MSVC's fetchRegressOpts() work at all?
| От | Tom Lane |
|---|---|
| Тема | Re: How does MSVC's fetchRegressOpts() work at all? |
| Дата | |
| Msg-id | 23571.1431970113@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Re: How does MSVC's fetchRegressOpts() work at all? (Andrew Dunstan <andrew@dunslane.net>) |
| Ответы |
Re: How does MSVC's fetchRegressOpts() work at all?
|
| Список | pgsql-hackers |
Andrew Dunstan <andrew@dunslane.net> writes:
> On 05/18/2015 12:48 PM, Tom Lane wrote:
>> Looking at vcregress.pl's sub fetchRegressOpts, it seems that it only
>> notices "REGRESS_OPTS =" lines not "REGRESS_OPTS +=" lines, so that
>> isn't surprising --- but how is it that the tests *are* still loading
>> plpythonu and hstore_plpythonu? I grant that my Perl is weak, but
>> I don't see how this code would ever have dealt with either lines
>> using +=, or multiple assignments to REGRESS_OPTS. How come it worked
>> before?
> relevant code:
Oh man, that's ugly.
If I were to fix fetchRegressOpts so it picks up all the makefile's
additions to REGRESS_OPTS, would we be able to eliminate that hack?
Or do we need the python-version kluge anyway?
regards, tom lane
В списке pgsql-hackers по дате отправления: