Re: GCC memory barriers are missing "cc" clobbers

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: GCC memory barriers are missing "cc" clobbers
Дата
Msg-id 23561.1411135081@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: GCC memory barriers are missing "cc" clobbers  (Andres Freund <andres@2ndquadrant.com>)
Ответы Re: GCC memory barriers are missing "cc" clobbers  (Andres Freund <andres@2ndquadrant.com>)
Список pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-09-19 12:00:16 +0200, Andres Freund wrote:
>> But addl sets condition flags. So this really also needs a "cc" clobber?
>> Or am I missing something?

> What I missed is that x86 has an implied "cc" clobber for every inline
> assembly statement. So forget that.

While it might not be buggy as it stands, I think we should add the "cc"
rather than rely on it being implicit.  One reason is that people will
look at the x86 cases when developing code for other architectures, and
they could easily forget to add "cc" on machines where it does matter.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: jsonb format is pessimal for toast compression
Следующее
От: Rahila Syed
Дата:
Сообщение: Re: [REVIEW] Re: Compression of full-page-writes