Re: [HACKERS] Overhead for stats_command_string et al, take 2

Bruce Momjian <bruce@momjian.us> writes:
> Attached patch adds GUC 'update_process_title' to control ps display
> updates per SQL command.  Default to 'on'.  GUC name OK?

This is an ugly patch.  Why not *one* test of the GUC variable, inside
set_ps_display(), and no side-effects on callers?  You would need to
force an initial update from init_ps_display, but that only requires a
small amount of code refactoring inside ps_status.c.

The one place that might be worth having an external test on the GUC is
in lock.c, but then it should bypass the entire business of copying,
modifying, and restoring the title ... not just the two set_ps_display
calls.

            regards, tom lane