Re: BUG #4731: compile with -fast fails on ld: duplicate symbol _PGP_S2K_TYPE in pgp.o and pgp-mpi-openssl.o

"Ceriel Jacobs" <cerieljacobs@gmail.com> writes:
> ld: duplicate symbol _PGP_S2K_TYPE in pgp.o and pgp-mpi-openssl.o

I think at bottom that's a compiler/linker bug which you should mention
to Apple.  However, I see what is causing it: pgp.h contains

enum
{
    PGP_S2K_SIMPLE = 0,
    PGP_S2K_SALTED = 1,
    PGP_S2K_ISALTED = 3
} PGP_S2K_TYPE;

I think what was meant was

enum PGP_S2K_TYPE
{
    PGP_S2K_SIMPLE = 0,
    PGP_S2K_SALTED = 1,
    PGP_S2K_ISALTED = 3
};

because what the first one is doing is defining a global variable
that is of an anonymous enum type.

Marko, am I right that this is just a syntax mistake, and not
intentional creation of a variable?  There are several occurrences
of the pattern in pgp.h.

            regards, tom lane