Re: Add EXTRA_CFLAGS to configure

Andres Freund <andres@anarazel.de> writes:
> On 2015-10-28 11:42:28 -0400, Tom Lane wrote:
>> 1. Invent a "--with-werror" configure switch that causes -Werror to be
>> added to the CFLAGS, but not while running tests that it'd break.
>> 
>> 2. Explicitly filter -Werror out of the user-provided CFLAGS while running
>> tests that it'd break.

> I think either of these is fine - I've a slight preference for 2)
> because we already filter *FLAGS in a bunch of places and it seems a bit
> nicer to extend, should another similar case come up.

> Do you have a preference?

I'd go with #2 also, if it's not hard to implement.  Single-purpose
configure switches are a wart.
        regards, tom lane