Re: [HACKERS] pg_attribute.attisinherited ?

Alvaro Herrera <alvherre@atentus.com> writes:
> I'm thinking about the ONLY part in the grammar in ALTER TABLE... DROP
> COLUMN and RENAME COLUMN.  I think they should not be there:

Local DROP COLUMN is fine: it just causes the column to become
non-inherited in any children.  (Your patch for attisinherited will
need to cover this case.)

Local RENAME COLUMN does need to be prohibited, as does local ADD
COLUMN, as does local ALTER COLUMN if we ever allow changing column
type.  Basically we need to prohibit the column from becoming
incompatible with its children.

I don't agree with the notion of changing the grammar to achieve that,
btw.  Simpler and more friendly to add a specific error check in
(most likely place) utility/tcop.c.  Then if you try to say ONLY you'll
get a more useful complaint than "parse error".

            regards, tom lane