Re: Further patch for VS2005

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Further patch for VS2005
Дата
Msg-id 22740.1151354831@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Further patch for VS2005  ("Magnus Hagander" <mha@sollentuna.net>)
Ответы Re: Further patch for VS2005  ("Magnus Hagander" <mha@sollentuna.net>)
Список pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
> *** src/pl/plpython/plpython.c    25 Jun 2006 00:18:24 -0000    1.83
> --- src/pl/plpython/plpython.c    26 Jun 2006 13:58:56 -0000
> ***************
> *** 10,16 ****
> --- 10,19 ----
>   /* Python uses #pragma to bring in a non-default libpython on VC++ if
>    * _DEBUG is defined */
>   #undef _DEBUG
> + /* Also hide away errcode, since we load Python.h before postgres.h */
> + #define errcode __vc_errcode
>   #include <Python.h>
> + #undef errcode
>   #define _DEBUG
>   #else
>   #include <Python.h>

BTW, it strikes me as a fairly bad idea to be including <Python.h>
first; that goes directly against the conventions we established to be
sure that largefile support doesn't break.  Has anyone looked into
making plpython.c conform to project standards by including postgres.h
first?

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: "Magnus Hagander"
Дата:
Сообщение: Further patch for VS2005
Следующее
От: "Magnus Hagander"
Дата:
Сообщение: Re: Further patch for VS2005