Re: Fix logical decoding not track transaction duringSNAPBUILD_BUILDING_SNAPSHOT

At 2025-11-22 18:34:23, "cca5507" <cca5507@qq.com> wrote:
>One important thing is that we must not skip any call to ReorderBufferXidSetCatalogChanges() (direct or indirect) during fast-forwarding or building snapshot, because the historic snapshot only tracks txns with catalog changes, the v6-0004 seems to skip it in xact_decode().
>
v6-0004 only skip the transaction commited during START state and precedeing next_phase_at
(set when changing to BUILDING_SNAPSHOT state) during BUILDING_SNAPSHOT. Those transactions
are always useless no matter in fast forward or not. Plaese recheck v6-0004 again.

>Here is a related bug:
>
>https://www.postgresql.org/message-id/flat/tencent_3A071B760AA1A38540B57F297332B7781C08%40qq.com
>

Yeah, I have researched that issue. I think your analyze is correct for me. But it is
independent of this thread. Let's discuss it in thread where the issues belongs to.

Best regards,
Haiyang Li