Re: knngist patch support

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: knngist patch support
Дата
Msg-id 22481.1266168299@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: knngist patch support  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: knngist patch support  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> OK.  In that case, any objections to my applying the attached patch,
> which I believe implements this as you suggested?

Um, did you test this version?  It looks like the macros are still
defined according to the idea that SearchSysCache takes five arguments.

Also, I'd suggest adding explicit comments to syscache.h suggesting
that SearchSysCache etc are meant to be called via the macros
rather than directly.

I didn't check all the individual calls, but it looks generally
sane except for those points.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Ross J. Reedstrom"
Дата:
Сообщение: Re: function to display ddl
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb)