Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID
Дата
Msg-id 22429D61-7958-4990-B254-F3E32463DE9A@yesql.se
обсуждение исходный текст
Ответ на Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-bugs
> On 12 Jun 2019, at 04:36, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Tue, Jun 11, 2019 at 09:32:55AM -0400, Alvaro Herrera wrote:
>> Yeah, looks better.  I think the error message should be a normal elog()
>> cache failure, though ... at least in the COMMENT case, the obj-does-not-
>> exist message is supposed to be thrown by get_object_address(), before
>> check_object_ownership is called.
>> 
>> As a matter of style, I would get rid of the 'conoid' variable and just
>> use address.objectId where needed.
> 
> OK.  I have included both your comments, and committed the patch down
> to 9.5 where it applies.  Thanks for the feedback!

Thanks!

> s/unathorized/unauthorized/ by the way.

Ugh, sorry about that.

cheers ./daniel



В списке pgsql-bugs по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID
Следующее
От: PG Bug reporting form
Дата:
Сообщение: BUG #15847: Running out of memory when planning full outer joins involving many partitions