Re: [COMMITTERS] pgsql: Identity columns

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [COMMITTERS] pgsql: Identity columns
Дата
Msg-id 22227.1491488685@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [COMMITTERS] pgsql: Identity columns  (Peter Eisentraut <peter_e@gmx.net>)
Ответы Re: [COMMITTERS] pgsql: Identity columns
Список pgsql-committers
Peter Eisentraut <peter_e@gmx.net> writes:
> Identity columns

This commit is causing a compiler warning for me:

tablecmds.c: In function 'ATExecSetIdentity':
tablecmds.c:5936: warning: 'address.objectSubId' may be used uninitialized in this function
tablecmds.c:5936: warning: 'address.objectId' may be used uninitialized in this function

I'm not sure why it's not complaining about all three fields, because
AFAICS, the function returns a totally undefined ObjectAddress when
generatedEl is not set.  What is the intention there?  (If the function
were adequately documented, maybe I could divine that for myself, but
heaven help the reader who would like to know what this function is
supposed to do.)

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()
Следующее
От: Simon Riggs
Дата:
Сообщение: [COMMITTERS] pgsql: Always SnapshotResetXmin() during ClearTransaction()