Neil Conway <neilc@samurai.com> writes:
> Tom Lane wrote:
>> [ scratches head... ] Did this code change recently? It's a tad hard
>> to believe that such a thing could have gone unnoticed for long.
> Seems the problem was introduced here:
> http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_db.c.diff?r1=1.58;r2=1.59
Oh dear, that makes it my fault :-(
> (I could just revert the code to using PQdb(), but I don't think there's
> a need to mention the database in the error message ourselves --
> PQerrorMessage() should include that information if appropriate.)
I'd go with reverting it to using PQdb, myself. Looks like I got bit by
the perennial mantra: premature optimization is the root of all evil.
regards, tom lane