Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend

Andres Freund <andres@2ndquadrant.com> writes:
> From: Andres Freund <andres@anarazel.de>
> c.h already had parts of the assert support (StaticAssert*) and its the shared
> file between postgres.h and postgres_fe.h. This makes it easier to build
> frontend programs which have to do the hack.

This patch seems unnecessary given that we already put a version of Assert()
into postgres_fe.h.  I don't think that moving the two different
definitions into an #if block in one file is an improvement.  If that
were an improvement, we might as well move everything in both postgres.h
and postgres_fe.h into c.h with a pile of #ifs.
        regards, tom lane