Re: [HACKERS] check_srf_call_placement() isn't always setting p_hasTargetSRFs

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [HACKERS] check_srf_call_placement() isn't always setting p_hasTargetSRFs
Дата
Msg-id 21818.1484593824@sss.pgh.pa.us
обсуждение исходный текст
Ответы Re: [HACKERS] check_srf_call_placement() isn't always setting p_hasTargetSRFs  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения 
Andres Freund <andres@anarazel.de> writes:
> Is there a reason not to just set p_hasTargetSRFs once towards the end
> of the function, instead of doing so for all the non-error cases?

Yes: it's not supposed to get set when the SRF is in FROM.

> I wonder if there should be a seperate expression type for
> the INSERT ... VALUES(exactly-one-row); since that behaves quite
> differently.

Perhaps.  Or maybe we should just use EXPR_KIND_SELECT_TARGET for that?
        regards, tom lane

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: [HACKERS] Implement targetlist SRFs using ROWS FROM() (wasChanged SRF in targetlist handling)
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)