Re: Pluggable Storage - Andres's take

Andres Freund <andres@anarazel.de> writes:
> On 2019-04-11 14:52:40 +0300, Heikki Linnakangas wrote:
>> +     * HEIKKI: A flags bitmask argument would be more readable than 6 booleans

> I honestly don't have strong feelings about it. Not sure that I buy that
> bitmasks would be much more readable

Sure they would be --- how's FLAG_FOR_FOO | FLAG_FOR_BAR not
better than unlabeled "true" and "false"?

> - but perhaps we could just use the
> struct trickery we started to use in

I find that rather ugly really.  If we're doing something other than a
dozen-or-so booleans, maybe its the only viable option.  But for cases
where a flags argument will serve, that's our longstanding practice and
I don't see a reason to deviate.

            regards, tom lane