Re: \xDD patch for 7.5devel

Jason Godden <jasongodden@optushome.com.au> writes:
> This is my first patch for PostgreSQL against the 7.5devel cvs (please
> advise if this is the wrong place to post patches).

pgsql-patches in future, please.

> +#define HEXVALUE(c) (((c)>='a') ? ((c)-87) : (((c)>='A') ? ((c)-55) : ((c)-'0')))

This seems excessively dependent on the assumption that the character
set is ASCII.  Why have you hard-coded numeric equivalents into this
macro?

BTW, the patch is incomplete because it is lacking documentation.
        regards, tom lane