Re: Missing PG_INT32_MIN in numutils.c

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Missing PG_INT32_MIN in numutils.c
Дата
Msg-id 21344.1460556690@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Missing PG_INT32_MIN in numutils.c  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: Missing PG_INT32_MIN in numutils.c  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Apr 13, 2016 at 9:38 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I am not very convinced that this is an improvement, because you took
>> what had been two hard-wired constants and replaced them with a symbol
>> and a hard-wired constant.This is more prone to break, not less so.

> I think it's kind of six of one, half a dozen of the other, but if you
> feel strongly about it, revert the patch.

I don't care enough to do that either, but I wanted to point out that
it's pretty questionable whether this is a stylistic improvement.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Следующее
От: José Luis Tallón
Дата:
Сообщение: Re: Parser extensions (maybe for 10?)