Antonin Houska <ah@cybertec.at> writes:
> StartupDecodingContext() initializes ctx->reader->private_data with ctx, and
> it even does so twice. I couldn't find a place in the code where the
> (LogicalDecodingContext *) pointer is retrieved from the reader, and a simple
> test of logical replication works if the patch below is applied. Thus I assume
> that assignment is a thinko, isn't it?
Hmm. The second, duplicate assignment is surely pointless, but I think
that setting the ctx as the private_data is a good idea. It hardly seems
out of the question that it might be needed in future.
regards, tom lane