Re: Ignore invalid indexes in pg_dump

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Ignore invalid indexes in pg_dump
Дата
Msg-id 21002.1364334450@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Ignore invalid indexes in pg_dump  (Michael Paquier <michael.paquier@gmail.com>)
Ответы Re: Ignore invalid indexes in pg_dump  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On top of checking indisvalid, I think that some additional checks on
> indislive and indisready are also necessary.

Those are not necessary, as an index that is marked indisvalid should
certainly also have those flags set.  If it didn't require making two
new version distinctions in getIndexes(), I'd be okay with the extra
checks; but as-is I think the maintenance pain this would add greatly
outweighs any likely value.

I've committed this in the simpler form that just adds indisvalid
checks to the appropriate version cases.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kevin Grittner
Дата:
Сообщение: Re: Drastic performance loss in assert-enabled build in HEAD
Следующее
От: Stefan Kaltenbrunner
Дата:
Сообщение: Re: spoonbill vs. -HEAD