Re: gratuitous casting away const

Mark Dilger <hornschnorter@gmail.com> writes:
> Would patches to not cast away const be considered?

In general, yes, but I'm not especially in favor of something like this:

>  bool
>  PageIndexTupleOverwrite(Page page, OffsetNumber offnum,
> -                                               Item newtup, Size newsize)
> +                                               const char *newtup, Size newsize)
>  {

since that seems to be discarding type information in order to add
"const"; does not seem like a net benefit from here.
        regards, tom lane