Re: s/LABEL/VALUE/ for ENUMs

"David E. Wheeler" <david@kineticode.com> writes:
> Patch attached.

Most of those changes seem like they make it less readable, not more so.
In particular I don't find it an improvement to replace "textual label"
with "textual value".  I think of "value" as meaning some abstract
notion of a particular enum member, which is not identical to the
concrete text string that represents it.  If you consider them the same
thing then renaming an enum value would be a meaningless concept.

Maybe instead of "textual label", we should say "name"?  But that
doesn't seem like quite le mot juste either.  "label" is actually a
pretty good word for the text representation of an enum value.
        regards, tom lane