Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much

Michael Paquier <michael.paquier@gmail.com> writes:
> On Sun, Oct 22, 2017 at 12:43 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> It doesn't seem very nice to have two identical(?) copies of
>> extract_variadic_args, especially since the same functionality
>> might be of use elsewhere.  I'm almost inclined to say that that
>> should go in funcapi.c/.h.

> More or less identical, the jsonb sibling enforces arguments of type
> unknown to text. I was considering first a common place where to put
> this stuff and thought about fmgr.c, but this has no dependency on
> FunctionCallInfo. I didn't think about this one, still do you think
> that's adapted? extract_variadic_args is quite json-ish with its text
> enforcement...

I don't think collecting all the arguments is particularly special ---
format() or concat() for instance could possibly use this.  You might
need an option to say what to do with unknown.
        regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs