Re: Repetition of warning message while REVOKE

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Repetition of warning message while REVOKE
Дата
Msg-id 20554.1267761614@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Repetition of warning message while REVOKE  (Stephen Frost <sfrost@snowman.net>)
Ответы Re: Repetition of warning message while REVOKE  (Stephen Frost <sfrost@snowman.net>)
Список pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> * Joshua D. Drake (jd@commandprompt.com) wrote:
>> Perhaps just add what can't be revoked? meaning:
>> WARNING:  no privileges could be revoked for "tbl" for column "foo"
>> Then they aren't actually duplicate.

> Yeah, they really aren't, after all.

Yeah, I agree JD's solution is probably the simplest reasonable answer.

> Attached is a patch to add column name to the error message when it's a
> column-level failure.  I'm not really thrilled with it, due to the
> expansion of code and addition of a bunch of conditionals, but at least
> this isn't a terribly complicated function..

It's a bit brute-force, but so was the original coding.  Anybody see
a way to make it cleaner/shorter?

One thought is that the column cases should be phrased more likeno privileges could be revoked for column "foo" of
table"bar"
 
Check the messages associated with DROP cascading for the canonical
phrasing here, but I think that's what it is.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: Repetition of warning message while REVOKE
Следующее
От: Craig Ringer
Дата:
Сообщение: Re: Visual Studio 2005, C-language function - avoiding hacks?