Jelte Fennema-Nio <postgres@jeltef.nl> writes:
> Looking at the committed version of this patch, the pg_unreachable
> calls seemed weird to me. 1 is actually incorrect, thus possibly
> resulting in undefined behaviour. And for the other call an imho
> better fix would be to remove the now 21 year unused enum variant,
> instead of introducing its only reference in the whole codebase.
If we do the latter, we will almost certainly get pushback from
distros who check for library ABI breaks. I fear the comment
suggesting that we could remove it someday is too optimistic.
regards, tom lane