Re: Trivial fixes for some IDENTIFICATION comment lines

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Trivial fixes for some IDENTIFICATION comment lines
Дата
Msg-id 20470.1453136462@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Trivial fixes for some IDENTIFICATION comment lines  (Andres Freund <andres@anarazel.de>)
Ответы Re: Trivial fixes for some IDENTIFICATION comment lines  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2016-01-18 12:52:06 +0100, Shulgin, Oleksandr wrote:
>> I've noticed that in src/backend/replication/logical/reorderbuffer.c, the
>> IDENTIFICATION comment line is incorrect:
>> 
>> * IDENTIFICATION
>> - *      src/backend/catalog/dropcmds.c
>> - *      src/backend/replication/logicalfuncs.c
>> - *      src/backend/replication/reorderbuffer.c
>> - *      src/backend/replication/snapbuild.c
>> - *      src/backend/storage/ipc/dsm.c
>> - *      src/backend/utils/cache/relfilenode.c
>> - *      src/backend/utils/cache/evtcache.c

> How about we simply drop them instead alltogether? This isn't exactly a
> seldomly made mistake, and they seem to actually contribute very little
> value?

Personally I think they're of some value.  Particularly with stuff like
Makefiles, which are otherwise confusingly similar.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thom Brown
Дата:
Сообщение: Re: Support for N synchronous standby servers - take 2
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: Combining Aggregates