Re: [PATCH] Incremental sort (was: PoC: Partial sort)

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Дата
Msg-id
20438.1586228437@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
[HACKERS] [PATCH] Incremental sort (was: PoC: Partial sort) Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort (was: PoC: Partial sort) Robert Haas <robertmhaas@gmail.com>
Re: [HACKERS] [PATCH] Incremental sort (was: PoC: Partial sort) Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort (was: PoC: Partial sort) Mithun Cy <mithun.cy@enterprisedb.com>
Re: [HACKERS] [PATCH] Incremental sort (was: PoC: Partial sort) Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Heikki Linnakangas <hlinnaka@iki.fi>
Re: [PATCH] Incremental sort David Steele <david@pgmasters.net>
Re: [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [PATCH] Incremental sort Andres Freund <andres@anarazel.de>
Re: [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [PATCH] Incremental sort Andres Freund <andres@anarazel.de>
Re: [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [PATCH] Incremental sort Andres Freund <andres@anarazel.de>
Re: [PATCH] Incremental sort Robert Haas <robertmhaas@gmail.com>
Re: [PATCH] Incremental sort Andres Freund <andres@anarazel.de>
Re: [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Robert Haas <robertmhaas@gmail.com>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Robert Haas <robertmhaas@gmail.com>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Antonin Houska <ah@cybertec.at>
Re: [HACKERS] [PATCH] Incremental sort Antonin Houska <ah@cybertec.at>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Antonin Houska <ah@cybertec.at>
Re: [HACKERS] [PATCH] Incremental sort Peter Geoghegan <pg@bowt.ie>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Robert Haas <robertmhaas@gmail.com>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Peter Geoghegan <pg@bowt.ie>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort Peter Geoghegan <pg@bowt.ie>
Re: [HACKERS] [PATCH] Incremental sort Alexander Korotkov <a.korotkov@postgrespro.ru>
Re: [HACKERS] [PATCH] Incremental sort (was: PoC: Partial sort) Michael Paquier <michael.paquier@gmail.com>
Tomas Vondra  writes:
> I came to the same conclusion (that the change in TuplesortMethod
> definiton is the culprit) a while ago and was about to push a fix that
> initialized it correctly in ExecSortInitializeDSM. But I agree reverting
> it back to the old definition is probably better.

Yeah, for the moment.  James would like to not have
SORT_TYPE_STILL_IN_PROGRESS be part of the enum at all, I think,
and I can see his point --- but then we need some out-of-band
representation of "worker not done", so I'm not sure there'll be
any net reduction of cruft.  Anyway that can be dealt with after
we have a stable buildfarm.

Note also that there's a separate comment-only patch in

that shouldn't be forgotten about.

			regards, tom lane


В списке pgsql-hackers по дате отправления
От: Tomas Vondra
Дата:
От: Kyotaro Horiguchi
Дата:
FAQ