Re: small patch to crypt.c

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: small patch to crypt.c
Дата
Msg-id 20363.1370795293@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: small patch to crypt.c  (Stephen Frost <sfrost@snowman.net>)
Ответы Re: small patch to crypt.c  ("Joshua D. Drake" <jd@commandprompt.com>)
Список pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> Regardless, setting vuntil to some magic value that really means "it's
> actually NULL", which is what you'd need to do in order to get rid of
> that explicit check for null, doesn't strike me as a good idea.  When a
> value is null, we shouldn't be looking at the data at all.

Even aside from that, the proposed change seems like a bad idea because
it introduces an unnecessary call of GetCurrentTimestamp() in the common
case where there's no valuntil limit.  On some platforms that call is
pretty slow.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Re: [COMMITTERS] pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding
Следующее
От: "Joshua D. Drake"
Дата:
Сообщение: Re: small patch to crypt.c