Re: HandleParallelMessages contains CHECK_FOR_INTERRUPTS?

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: HandleParallelMessages contains CHECK_FOR_INTERRUPTS?
Дата
Msg-id
20300.1470170558@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
HandleParallelMessages contains CHECK_FOR_INTERRUPTS? Tom Lane <tgl@sss.pgh.pa.us>
Re: HandleParallelMessages contains CHECK_FOR_INTERRUPTS? Alvaro Herrera <alvherre@2ndquadrant.com>
Re: HandleParallelMessages contains CHECK_FOR_INTERRUPTS? Tom Lane <tgl@sss.pgh.pa.us>
Re: HandleParallelMessages contains CHECK_FOR_INTERRUPTS? Tom Lane <tgl@sss.pgh.pa.us>
I wrote:
> Alvaro Herrera  writes:
>> I notice you just removed the CHECK_FOR_INTERRUPTS in
>> HandleParallelMessages().  Did you notice that HandleParallelMessages
>> calls shm_mq_receive(), which calls shm_mq_receive_bytes(), which
>> contains a CHECK_FOR_INTERRUPTS() call?

After study, I believe that that CHECK_FOR_INTERRUPTS() is unreachable
given that HandleParallelMessages passes nowait = true.  But it's not
unlikely that future changes in shm_mq.c might introduce such calls that
are reachable.

> I wonder whether we should make use of HOLD_INTERRUPTS/RESUME_INTERRUPTS
> to avoid the recursion scenario here.

I concluded that that would be good future-proofing, whether or not it's
strictly necessary today, so I pushed it.
		regards, tom lane


В списке pgsql-hackers по дате отправления
От: Stephen Frost
Дата:
Сообщение: Re: Why we lost Uber as a user
От: Alvaro Herrera
Дата:
Сообщение: Re: PostgreSQL 10 kick-off
FAQ