Re: Adding REPACK [concurrently]

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Adding REPACK [concurrently]
Дата
Msg-id 202604041351.dxbbzgqqwdgk@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Adding REPACK [concurrently]  (Srinath Reddy Sadipiralla <srinath2133@gmail.com>)
Список pgsql-hackers
On 2026-Apr-04, Srinath Reddy Sadipiralla wrote:

> yes indeed , TotalMaxReplicationSlots was the culprit , as the window
> after getting repack worked was forked , i think this was set back to 0.
> Thanks for fixing this with "repack" flag , initially i thought why can't we
> go with a macro
> #define TotalMaxReplicationSlots (max_replication_slots +
> max_repack_replication_slots)
> but i thought maybe in future we might need this "repack" flag to add
> more slot requirements.

Yeah, the other option would have been to add the variable to
restore_backend_variables() so that it's restored after the fork+exec,
but that didn't seem better.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Niemand ist mehr Sklave, als der sich für frei hält, ohne es zu sein."
       Nadie está tan esclavizado como el que se cree libre no siéndolo
                                           (Johann Wolfgang von Goethe)



В списке pgsql-hackers по дате отправления: