Re: remove the unneeded header file math.h in binaryheap.c
| От | Álvaro Herrera |
|---|---|
| Тема | Re: remove the unneeded header file math.h in binaryheap.c |
| Дата | |
| Msg-id | 202601131402.kjp7ceoxgr44@alvherre.pgsql обсуждение исходный текст |
| Ответ на | remove the unneeded header file math.h in binaryheap.c ("liujinyang" <21043272@qq.com>) |
| Ответы |
Re: remove the unneeded header file math.h in binaryheap.c
|
| Список | pgsql-hackers |
On 2026-Jan-13, liujinyang wrote: > Hi Hackers, > > I found in file binaryheap.c, file "math.h" was included, but it is uncessary, so I removed it > and filing a patch to address the issue. Fun. This was already unnecessary at commit 7a2fe9bd0371 which introduced the file. It seems Abhijit had that include in his first version [1] because he was using floor(). Robert rewrote it later [2] and replaced that with straight arithmetic, making the include unnecessary, but forgot to remove it. [1] https://postgr.es/m/20121114131112.GA27771@toroid.org [2] https://postgr.es/m/CA%2BTgmobvR7XW9fjj2RNY7sKK-VAG5nahfai_zV51rHVLDNvaBg%40mail.gmail.com -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
В списке pgsql-hackers по дате отправления: