On 2025-Oct-06, Dilip Kumar wrote:
> I think we can fix it in getTableAttrs(), see attached, with that I
> can see my dump is correct. This is just a quick way to show what I
> am thinking, maybe we can improve this condition.
Pushed, thanks. I added a test so that cross-version upgrade will hit
this. Because this code is not used except when upgrading from 17 or
older, I had to modify 17 even though that version needs no code changes
itself. (I verified that the pg_upgrade test fails if I have this table
in a pg_dumpall from version 17 -- and the diff is exactly this missing
NOT NULL constraint.)
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)