> Looking around, there is only one in-core caller of
> WinGetFuncArgInPartition, and it does pass a valid "isout" pointer,
> explaining why this inconsistency wasn't obvious in testing.
> There are outside callers though according to Debian Code Search,
> and at least PostGIS is one that passes a null pointer.
>
> As Alvaro notes nearby, this function is ridiculously complicated
> already. I'm tempted to remove the API allowance for isout == NULL,
> and thereby simplify the code slightly, rather than complicate it more
> by continuing to allow that. We'd have to warn the PostGIS people
> about the API change though.
It think it's a good idea.
Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp