Re: Test instability when pg_dump orders by OID

On Wed, Aug 20, 2025 at 10:11:15AM +0500, Kirill Reshke wrote:
> On Sun, 10 Aug 2025 at 21:37, Noah Misch <noah@leadboat.com> wrote:
> > Thanks.  Given the current state of freeze for tomorrow's release wrap, the
> > decision is less obvious than usual.  I'm seeing these options:
> >
> > 1. Remove the new assertion in v13-v18.
> > 2. Push your proposed fix.
> > 3. Change nothing.  (This would be the choice if one is maximally concerned
> >    about deviating from the freeze and unconcerned about --enable-cassert
> >    builds of releases.)
> >
> > I am inclined to make today's change be (1).  A fresh audit of catalog PRIMARY
> > KEY and UNIQUE constraints didn't find any more missed cases, but (1) still
> > feels like the right level of cautiousness.  If there are no objections in the
> > next 3hr, I'll proceed with (1).
> 
> Hi! I can see we have option (1)  (28e7252 etc). Can we now move
> forward with option (2) for HEAD?

Yep.  It's in my queue.