Re: trivial grammar refactor

Поиск
Список
Период
Сортировка
От Álvaro Herrera
Тема Re: trivial grammar refactor
Дата
Msg-id 202507240954.uage7twscx4s@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: trivial grammar refactor  (Andres Freund <andres@anarazel.de>)
Ответы Re: trivial grammar refactor
Список pgsql-hackers
Hello,

On 2025-Jul-23, Andres Freund wrote:

> On 2025-07-23 19:59:52 +0200, Álvaro Herrera wrote:
> > ... so using the same set of productions, I can rewrite the current
> > CLUSTER rule in this way and it won't be a problem for the REPACK
> > changes.
> 
> But it comes at the price of henceforth duplicating all ClusterStmt, once for
> VERBOSE and once without. That's not exactly a free lunch...

Yeah, thanks for taking a look.  That duplication is just me being dumb.
Here's a version without that.  The only thing that needed to change was
changing "CLUSTER opt_verbose" to "CLUSTER VERBOSE" so that the
unadorned CLUSTER is handled by "CLUSTER opt_utility_option_list"
instead.


-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"How amazing is that? I call it a night and come back to find that a bug has
been identified and patched while I sleep."                (Robert Davidson)
               http://archives.postgresql.org/pgsql-sql/2006-03/msg00378.php

Вложения

В списке pgsql-hackers по дате отправления: