Hi,
On Sun, 13 Jul 2025 23:15:24 +0900
Rintaro Ikeda <ikedarintarof@oss.nttdata.com> wrote:
> I noticed one small thing I’d like to discuss. I'm not sure that users clearly
> understand which aborted in the following error message, the client or the script.
> > pgbench: error: client 0 script 0 aborted in command ... query ...
>
> Since the code path always results in a client abort, I wonder if the following
> message might be clearer:
> > pgbench: error: client 0 aborted in script 0 command ... query ...
Indeed, it seems clearer to explicitly state that it is the client that
was aborted.
I've attached an updated patch that replaces the remaining message mentioned
above with a call to commandFailed(). With this change, the output in such
situations will now be:
"client 0 aborted in command 0 (SQL) of script 0; ...."
Regards,
Yugo Nagata
--
Yugo Nagata <nagata@sraoss.co.jp>