Re: ABI Compliance Checker GSoC Project

On 2025-Jun-03, Mankirat Singh wrote:

> On Tue, 3 Jun 2025 at 20:49, Álvaro Herrera <alvherre@kurilemu.de> wrote:

> > Please elaborate.  Can you not write a suppression file that says
> > "ignore offset changes for ios_in_progress in ReadStream", for example?
> 
> I can do that, and that's what's causing the problem. According to
> the documentation for these suppression files[1], we have to mention
> the particular symbol name we need to suppress like "ReadStream" or
> something particular like "ignore offset changes for ios_in_progress
> in ReadStream between member1 and member 2" which is humanly very hard
> to do as for sure there will be 100s of symbols in postgres like this
> which needs to be ignored in that case.

Well, now that I grep the source for ReadStream, I realize that the
struct is defined in a .c file, not in any .h files, so you're right
that the tooling needs a way to understand that changes to this symbol
must not raise any alarms; and that way must not involve a manually
written suppression file.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
Officer Krupke, what are we to do?
Gee, officer Krupke, Krup you! (West Side Story, "Gee, Officer Krupke")