On 2025-Feb-03, Sergey Tatarintsev wrote:
> Thanks for the note. I changed the query in the patch (v2 patch attached)
>
> Btw, an additional benefit from the patch is that we can use foreign tables
> (for example, to test postgres_fdw optimizations)
Good thought, and maybe it would be better if the new function was
"get_table_relkind" which just returns the char, and this check
> + /* Use COPY with FREEZE on v14 and later for all regular tables */
> + if ((PQserverVersion(con) >= 140000) && is_regular_table(con, table))
> copy_statement_fmt = "copy %s from stdin with (freeze on)";
can be "&& get_table_relkind(con, table) == RELKIND_RELATION"
which I think is more natural.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/