Re: [PATCH] Add SIGCHLD catch to psql

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] Add SIGCHLD catch to psql
Дата
Msg-id 20249.1273968563@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCH] Add SIGCHLD catch to psql  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: [PATCH] Add SIGCHLD catch to psql  (Bruce Momjian <bruce@momjian.us>)
Re: [PATCH] Add SIGCHLD catch to psql  (Stephen Frost <sfrost@snowman.net>)
Список pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, May 15, 2010 at 7:46 PM, David Fetter <david@fetter.org> wrote:
>> Wouldn't this count as a bug fix?

> Possibly, but changes to signal handlers are pretty global and can
> sometimes have surprising side effects.  I'm all in favor of someone
> reviewing the patch - any volunteers?  One case to test might be
> reading input from a file that contains \! escapes.  More generally,
> we need to consider every way that psql can get SIGCHLD and think
> about whether this is the right behavior.

I think this will introduce far more bugs than it fixes.  A saner
approach, which would also help for other corner cases such as
out-of-disk-space, would be to check for write failures on the output
file and abandon the query if any occur.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Renner
Дата:
Сообщение: Unexpected page allocation behavior on insert-only tables
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Unexpected page allocation behavior on insert-only tables