Re: [PATCH] Add SIGCHLD catch to psql

Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, May 15, 2010 at 7:46 PM, David Fetter <david@fetter.org> wrote:
>> Wouldn't this count as a bug fix?

> Possibly, but changes to signal handlers are pretty global and can
> sometimes have surprising side effects.  I'm all in favor of someone
> reviewing the patch - any volunteers?  One case to test might be
> reading input from a file that contains \! escapes.  More generally,
> we need to consider every way that psql can get SIGCHLD and think
> about whether this is the right behavior.

I think this will introduce far more bugs than it fixes.  A saner
approach, which would also help for other corner cases such as
out-of-disk-space, would be to check for write failures on the output
file and abandon the query if any occur.
        regards, tom lane