Re: Enhance create subscription reference manual

Поиск
Список
Период
Сортировка
От Tatsuo Ishii
Тема Re: Enhance create subscription reference manual
Дата
Msg-id 20241003.122334.571467902804061693.ishii@postgresql.org
обсуждение исходный текст
Ответ на Re: Enhance create subscription reference manual  (Yugo Nagata <nagata@sraoss.co.jp>)
Ответы Re: Enhance create subscription reference manual
Re: Enhance create subscription reference manual
Список pgsql-hackers
> parameter in this case (it is an "optional" parameter, though). However,
> when we refer to the stored catalog value, we should call it an option or
> a property and calling it parameter is not suitable.

Not sure. The stored catalog value of a subscription can be changed
ALTER SUBSCRIPTION. In the ALTER SUBSCRIPTION manual, the placeholders
for these properties are "parameter". So I think we should use
"parameter" in this case at least for the stored catalog values of
subscriptions.

> If so, I feel that "the failover" in the following statement means
> the catalog value (or the failover feature itself), so we should not
> rewrite this to "the failover parameter".

My conclusion is we should rewrite it as "the failover parameter" for
the reason above.

>> To initiate replication, you must manually create the replication slot, 
>> enable the failover if required, enable the subscription, and refresh the
>> subscription.
> 
> Instead, should we use "failover option"?

Yes. because "enable the failover" actually means an operation using
ALTER SUBSCRIPTION IMO.

> Or, if it would mean to the failover
> feature rather than the parameter, is it not proper to add <literal> tag to this
> "failover"?

I don't think so.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp



В списке pgsql-hackers по дате отправления: