Re: CompilerWarnings task does not catch C++ warnings

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: CompilerWarnings task does not catch C++ warnings
Дата
Msg-id 20240618143116.sgjwk3aynyv5wlw3@awork3.anarazel.de
обсуждение исходный текст
Ответ на CompilerWarnings task does not catch C++ warnings  (Peter Eisentraut <peter@eisentraut.org>)
Список pgsql-hackers
Дерево обсуждения 
Hi,

On 2024-06-18 09:27:02 +0200, Peter Eisentraut wrote:
> The CompilerWarnings task on Cirrus CI does not catch warnings in C++ code.
> It tries to make warnings fatal by passing COPT='-Werror', but that does not
> apply to C++ compilations.
> 
> I suggest that we just add COPT to CXXFLAGS as well.  I think passing
> -Werror is just about the only reasonable use of COPT nowadays, so making
> that more robust seems useful.  I don't think there is a need for a separate
> make variable for C++ here.

+1

Greetings,

Andres Freund

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Yura Sokolov
Дата:
Сообщение: Re: Suggest two small improvements for PITR.
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Truncation of mapped catalogs (whether local or shared) leads to server crash