At Tue, 4 Jun 2024 08:30:19 +0900, Michael Paquier <michael@paquier.xyz> wrote in
> On Mon, Jan 15, 2024 at 01:34:46PM -0500, Robert Haas wrote:
> > This kind of change looks massively helpful to me. I don't know if it
> > is exactly right or not, but it would have been a big help to me when
> > writing my previous review, so +1 for some change of this general
> > type.
>
> During a live review of this patch last week, as part of the Advanced
> Patch Workshop of pgconf.dev, it has been mentioned by Tom that we may
> be able to simplify the check on pmstart if the detection of the
> postmaster PID started by pg_ctl is more stable using the WIN32
> internals that this patch relies on. I am not sure that this
> suggestion is right, though, because we should still care about the
> clock skew case as written in the surrounding comments? Even if
> that's OK, I would assume that this should be an independent patch,
> written on top of the proposed v6-0001.
>
> Tom, could you comment about that? Perhaps my notes did not catch
> what you meant.
Thank you for the follow-up.
I have been thinking about this since then. At first, I thought it
referred to FindFirstChangeNotification() and friends, and inotify on
Linux. However, I haven't found a way to simplify the specified code
area using those APIs.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center